Add guard against missing original.parentNode #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the test failure seen here: https://travis-ci.org/backspace/prison-rideshare-ui/builds/530523899#L578
|
I should have linked to the tests for the following commit when I changed to this fork and the It looks like the test failures are existing and unrelated to this PR 😞 |
|
Seems like during tests, the parent could be destroyed, and there's no need to add the cloned element for animation. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a naïve fix for a problem I was experiencing in tests after updating Ember Paper, you can see an example here:
https://travis-ci.org/backspace/prison-rideshare-ui/builds/530523899#L578
It seems somewhat akin to what’s discussed in #925, but I’m definitely at the limit of my understanding of what’s happening. I only encountered this problem in tests.
Let me know if I can provide any details from the application that might help solve this differently.