New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fixes #1128] Protect against null querySelector in PaperMenu#focusItem #1129

Merged

miguelcobain merged 2 commits into miguelcobain:master from boydkr:paper-menu-items-disabled

May 9, 2020

Contributor

boydkr commented Feb 18, 2020 •

edited

Fixes #1128
Check for existence of query selector before getting first child

boydkr added 2 commits

February 18, 2020 14:30


          Check for existence of query selector before getting first child

727e78d


          line ending

67a2e08

Owner

miguelcobain commented Feb 18, 2020

You make a good point. A menu without focusable options is still a valid menu!

Thank you for the PR with the test. 💯

miguelcobain mentioned this pull request

PaperMenu focusItem breaks if all menu items are disabled #1128

Closed

miguelcobain merged commit 48f7ad5 into miguelcobain:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment