Fix [1142] remaining mouseEnter/mouseLeave deprecations by adding eve… #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.element.removeEventListener('mouseleave', this._mouseLeaveHandler); | ||
|
|
||
| this._mouseEnterHandler = undefined; | ||
| this._mouseLeaveHandler = undefined; |
There was a problem hiding this comment.
@fpauser Why do we have to define a handler property to store the action and then clear it in will destroy ? Instead we can directly assign the actions to event listener and remove it in will destroy hook.
There was a problem hiding this comment.
Its needed because bind() returns a new function bound to this with each call. To have removeEventListener remove our handler we have to give it the exact same handler function that was given to addEventHandler.
this.handleMouseEnter.bind(this) !== this.handleMouseEnter.bind(this)There was a problem hiding this comment.
Otherwise we'd produce leaks.
There was a problem hiding this comment.
That is a good insight. Thanks
|
Can we have a fresh release with the fix? |
|
Thanks, @fpauser! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nt listeners