Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use click instead of mouseUp to clear autocomplete (allowClear=true) #1147

Merged
merged 1 commit into from
Jun 12, 2020
Merged

Use click instead of mouseUp to clear autocomplete (allowClear=true) #1147

merged 1 commit into from
Jun 12, 2020

Conversation

alex9nadon
Copy link
Contributor

@alex9nadon alex9nadon commented May 11, 2020 •
edited

Click works on both mobile and desktop.

Fixes #1138 & #882

@alex9nadon
Replace mouseUp() -> click()
dfd83d7 
Click works on both mobile and desktop.
@alex9nadon alex9nadon mentioned this pull request May 11, 2020
Closed
@alex9nadon
Copy link
Contributor Author

alex9nadon commented May 11, 2020 •
edited

MouseUp and TouchEnd allow users to changes his mind by releasing out of the reset button.
But it dosen't work's on both mobile & desktop.
I ended up using click instead, at lease it work's on both.

@miguelcobain miguelcobain merged commit 2807425 into miguelcobain:master Jun 12, 2020
@miguelcobain
Copy link
Owner

Thank you @alex9nadon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

autocomplete allowclean does not work on mobile device
2 participants
@alex9nadon @miguelcobain