Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update blocking dependencies and codebase #1201

Conversation

Subtletree
Copy link
Collaborator

@Subtletree Subtletree commented Dec 17, 2021

Had some spare work time at the end of the year to remove deprecations and blocking dependencies. I know ember-paper is basically unmaintained at this stage but this move for now is easier than moving to something else or moving to styles other than angular-material v1...

  • Updated ember-basic-dropdown and ember-power-select and refactored relevant code.
  • Updated dummy app to ember/ember-cli 3.28.
  • Removed/updated outdated dependencies.

Everything's ready to go as far as I know except for the toast css-transitions. Hopefully wrap that up on monday.

closes #1180, closes #1179, closes #1176, closes #1166, closes #1175, closes #1191, closes #1192, closes #1165, closes #1067, closes #808, closes #967, closes #925, closes #777, closes #688, closes #635

@miguelcobain
Copy link
Owner

Thank you so much for this. 👍

@Subtletree Subtletree force-pushed the update-blocking-dependencies-and-code branch 2 times, most recently from 11dfc61 to f04508f Compare December 21, 2021 02:17
@Subtletree Subtletree force-pushed the update-blocking-dependencies-and-code branch 3 times, most recently from de63053 to d9e547d Compare January 12, 2022 02:43
@Subtletree Subtletree changed the title WIP: Update blocking dependencies and code Update blocking dependencies and codebase Jan 17, 2022
@Subtletree Subtletree force-pushed the update-blocking-dependencies-and-code branch from d9e547d to f710607 Compare January 18, 2022 00:37
@Subtletree
Copy link
Collaborator Author

@miguelcobain This is good to go. We've been using in production for a week and ironed out a couple of issues. More might crop up but I'm happy to fix bugs related to this as they come up.

Should let people upgrade to 3.28 LTS atleast and we can evaluate what more needs to be done and if it's worth supporting ^4 without changing from angular styles v1.

@miguelcobain
Copy link
Owner

@Subtletree I gave you permission to update the repository and the npm package. Hopefully you can bring this project to a decent place.
You have my utmost respect, sir.

@creising
Copy link

@Subtletree you are a legend! Thank you for this!

@Subtletree Subtletree merged commit b8401c6 into miguelcobain:master Jan 24, 2022
@Subtletree
Copy link
Collaborator Author

@Subtletree I gave you permission to update the repository and the npm package. Hopefully you can bring this project to a decent place. You have my utmost respect, sir.

What an honour! I can't promise to continue upkeep in the long term but if others are still interested we might be able to keep EP alive.

Thanks so much for the work you've put in with ember-paper over the years. What a major effort keeping it rolling since 2014!

Version 1.0.0-beta.36 is published 🎉

@Subtletree Subtletree mentioned this pull request Mar 4, 2022
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment