Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: paper-progress-circular component #136

Merged

Conversation

peec
Copy link
Contributor

@peec peec commented Jul 19, 2015

  • Converted from ember-material-design
  • Added tests
  • Uses the new color mixin just as paper-progress-linear.

@miguelcobain
Copy link
Owner

Perfect!
Just two things:

  1. I'm trying to avoid any md- in the public API, just like I did with paper-linear-progress. Can we do the same here?
  2. Can you update the CHANGELOG.md

@peec
Copy link
Contributor Author

peec commented Jul 19, 2015

@miguelcobain Ah, didn't notice the md attributes, updated PR with removed md- syntax and changelog.

@miguelcobain miguelcobain merged commit d8c0a91 into miguelcobain:master Jul 20, 2015
@miguelcobain
Copy link
Owner

Tests are failing. #137

I merged the changes anyway, because I believe nothing was changed on ember-paper to cause those fails.

Also added some logic that allows progress-linear and circular to infer the mode they should work on based on the passed in values. I believe this makes the API a bit friendlier.

Excellent work. Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants