Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Listen for model changes #178

Merged
merged 3 commits into from
Nov 23, 2015
Merged

Listen for model changes #178

merged 3 commits into from
Nov 23, 2015

Conversation

TNAJanssen
Copy link
Contributor

When changing model, change searchText

@TNAJanssen
Listen for model changes
88a55bf 
When changing model, change searchText
@TNAJanssen
Copy link
Contributor Author

@miguelcobain when do you have time to check this PR?

@miguelcobain
Copy link
Owner

@TNAJanssen looks good.

Two things:

  • please use ' instead of " to conform the code style
  • can you please add an entry to the changelog?

@TNAJanssen
Copy link
Contributor Author

@miguelcobain will do!

@TNAJanssen
Copy link
Contributor Author

@miguelcobain what version number?

@miguelcobain
Copy link
Owner

Under 0.2.9, and update date, please.

@TNAJanssen
Copy link
Contributor Author

@miguelcobain done

@TNAJanssen
Copy link
Contributor Author

@miguelcobain can you merge this

@miguelcobain miguelcobain mentioned this pull request Oct 27, 2015
Closed
@miguelcobain miguelcobain merged commit e1e4494 into miguelcobain:master Nov 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TNAJanssen @miguelcobain