Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paper input #319

Closed
wants to merge 29 commits into from
Closed

Conversation

DanChadwick
Copy link
Contributor

Convert paper-input to ember-paper 1.0 standards.

  • Convert to ember-paper 1.0 coding standards.
  • Convert validation to computed properties.
  • Unify internal validations, custom validations, and external validation messages.
  • Support displaying multiple validations at once a la Angular Material 2.0.
  • Support the required asterisk a la Angular Material 2.0.
  • Fix the display of inputs with an icon on the left.
  • Change the passing of passthru attributes from attr- to passThru.
  • Change focus in/out events to require action closures.
  • Numerous improvement to the dummy app documentation page.
  • Allow required asterisk styling without required validation (useful for external validation messages that implement required validation). required="style" sets only the styling, but performs no validation. If the html5 required attribute is desired instead, use passThru.
  • Update documentation page for change to passThru attributes.
  • Update tests for API changes.
  • Document API changes in CHANGELOG.md

…1.1 to 1.0.6.

The app/styles/backports/paper-input.scss file can be deleted when updated to angular material 1.0.6.
@DanChadwick
Copy link
Contributor Author

Test failures are due to paper-dialog, not this PR.

@miguelcobain miguelcobain added this to the 1.0 milestone Mar 28, 2016
classNameBindings: ['hasValue:md-input-has-value', 'focus:md-input-focused', 'isInvalid:md-input-invalid', 'iconFloat:md-icon-float'],
classNameBindings: [
'hasValue:md-input-has-value',
'focus:md-input-focused',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BaseFocusable handles this. Also, focus isn't used anymore. BaseFocusable uses focused.

@miguelcobain
Copy link
Owner

icon-class should be camelCased, correct?

return valueIsInvalid;
},
let validationErrors = this.get('validationErrors');
if (validationErrors && isArray(validationErrors)) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isArray already tests that validationErrors is truthy.

@miguelcobain
Copy link
Owner

  • Use icon="iconName" to include a left icon and iconRight="iconName" to include a right icon.
  • Use md-has-icon class when one of them is present (computed.or('icon','iconRight'))
  • Add md-icon-right class when iconRight is present

@DanChadwick
Copy link
Contributor Author

All set, but note that no-float applies to the label, not the container or icon. It prevents the label from floating up when you start to enter text. See the revised dummy app.

@miguelcobain
Copy link
Owner

Closed in favor of #326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants