-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paper input #319
Paper input #319
Conversation
… used when element hasn't been touched.
… listeners upon willDestroyElement.
…1.1 to 1.0.6. The app/styles/backports/paper-input.scss file can be deleted when updated to angular material 1.0.6.
…error messages at once.
Test failures are due to paper-dialog, not this PR. |
classNameBindings: ['hasValue:md-input-has-value', 'focus:md-input-focused', 'isInvalid:md-input-invalid', 'iconFloat:md-icon-float'], | ||
classNameBindings: [ | ||
'hasValue:md-input-has-value', | ||
'focus:md-input-focused', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BaseFocusable handles this. Also, focus
isn't used anymore. BaseFocusable uses focused
.
|
return valueIsInvalid; | ||
}, | ||
let validationErrors = this.get('validationErrors'); | ||
if (validationErrors && isArray(validationErrors)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isArray
already tests that validationErrors
is truthy.
… either an array of messages or hashes containing messages.
|
All set, but note that |
Closed in favor of #326 |
Convert paper-input to ember-paper 1.0 standards.
ember-paper
1.0 coding standards.attr-
topassThru.
required="style"
sets only the styling, but performs no validation. If the html5 required attribute is desired instead, usepassThru
.