Danchadwick wip buff up #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… reflect action requirement.
…ing action `action`.
…tyle update. When paper-select calls _super() in didReciveAttrs, it will trigger paper-input's assertion, not its own. Rather than assert before the call to _super, simply combine the messages.
Causes ember-paper to be watched during development of another application.
…l examples now function.
| - paper-menu now uses `value` instead of `model`. | ||
| - paper-checkbox now uses `value` instead of `checked`. | ||
| - paper-switch now uses `value` instead of `checked`. | ||
| - paper-select now uses required an `onchange` action. |
| @@ -19,9 +19,9 @@ export default Ember.Component.extend(RippleMixin, ProxyMixin, { | |||
|
|
|||
| hasProxiedComponent: Ember.computed.bool('proxiedComponents.length'), | |||
|
|
|||
| hasSecondaryAction: Ember.computed('secondaryItem', 'action', function() { | |||
| hasSecondaryAction: Ember.computed('secondaryItem', 'onClick', function() { | |||
There was a problem hiding this comment.
Why not destructure computed from Ember, just like in paper-input.js
There was a problem hiding this comment.
@xomaczar - Absolutely. The purpose of this PR was to make some API changes. The affected file has not been gone thru and adjusted to conform to the ember-paper style guides (in contributing.md). I only touch paper-item to get rid of all the "action" properties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update a broad variety of small items, bring other components into harmony with already-updated components. See commit messages for details.