Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't import hammerjs and match media if being called from node #347

Merged
merged 1 commit into from
Apr 26, 2016

Conversation

BenMorganIO
Copy link
Contributor

While adding Ember Fastboot support to an application, I was receiving:

$ ember fastboot --serve-assets
Built project successfully. Stored in "fastboot-dist".
Installing FastBoot npm dependencies
document is not defined
ReferenceError: document is not defined

This was because HammerJS and MatchMedia use the document, but NodeJS, which Fastboot uses, doesn't use the document, which leads the ReferenceError. Therefore, if Ember Fastboot is requiring ember-paper, lets skip HammerJS and MatchMedia.

@miguelcobain
Copy link
Owner

Thanks a lot. 👍

@BenMorganIO
Copy link
Contributor Author

BenMorganIO commented Apr 26, 2016

@miguelcobain if you could release a new bug fix version for Ember Fastboot support, that would super awesome :)

@SaladFork SaladFork merged commit 42910f8 into miguelcobain:master Apr 26, 2016
@BenMorganIO BenMorganIO deleted the ember-fastboot-support branch April 26, 2016 20:20
@SaladFork
Copy link
Contributor

For releasing a new version (pre 1.0.0) we will need to cherry-pick this to the release-0-2 branch.

@BenMorganIO
Copy link
Contributor Author

@SaladFork thanks :)

@SaladFork
Copy link
Contributor

@BenMorganIO Just released 0.2.14 with your fix. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants