can add CSS classes to paper dialog container #571
Conversation
| @@ -5,7 +5,7 @@ | |||
| fixed=(unless parent true) | |||
| class="md-dialog-backdrop" | |||
| onClick=(action "outsideClicked")}} | |||
| {{#paper-dialog-container outsideClicked=(action "outsideClicked")}} | |||
| {{#paper-dialog-container class=(readonly dialogContainerClasses) outsideClicked=(action "outsideClicked")}} | |||
There was a problem hiding this comment.
I think that class would be a better API than dialogContainerClasses, no?
Since paper-dialog is a tagless component, we can just transport the passed in classes to paper-dialog-container.
There was a problem hiding this comment.
I named it dialogContainerClasses for two reasons:
- consistency with other components (ex:
paper-select:class=(readonly concatenatedTriggerClasses)) - avoid collision because there is multiple component we can pass class to (container, inner, ..)
Or class for the container and innerClasses for paper-dialog-inner ?
There was a problem hiding this comment.
IMO:
classforpaper-dialog-inner, since this is the dialog itselfdialogContainerClassforpaper-dialog-container
paper-select component renders two things, a trigger and a dropdown. That's why we need to be more specific.
In this case this is just a "proxy" to render a single component, so there shouldn't be any confusion.
| test('can specify dialog container classes', function(assert) { | ||
| this.render(hbs` | ||
| <div id="paper-wormhole"></div> | ||
| {{paper-dialog dialogContainerClasses='flex-50 my-dialog-container'}} |
There was a problem hiding this comment.
For consistency project-wide, please use double quotes in everything template related.
panthony
force-pushed
the
feat/specify-dialog-container-classes
branch
from
6d8d581
to
523e560
Compare
panthony
force-pushed
the
feat/specify-dialog-container-classes
branch
from
17512de
to
14b8141
Compare
panthony
force-pushed
the
feat/specify-dialog-container-classes
branch
from
a337081
to
245046f
Compare
|
Perfect PR. 💯 |
Add the capability for the user to specify CSS classes to the paper dialog container if necessary.