Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blockless autocomplete #588

Closed
wants to merge 1 commit into from
Closed

Blockless autocomplete #588

wants to merge 1 commit into from

Conversation

xomaczar
Copy link
Contributor

No description provided.

@miguelcobain
Copy link
Owner

I think I see the point of this. We have to pass in labelPath anyway, so a blockless version might make sense.
I wish we could get rid of labelPath, but I don't think we can because of the input.

@xomaczar
Copy link
Contributor Author

Agree, labelPath is only needed when binding to the list of objects. The blockless version should cover the 80% of all the use cases.

@xomaczar
Copy link
Contributor Author

@miguelcobain ^

@xomaczar
Copy link
Contributor Author

Ping @miguelcobain

@miguelcobain
Copy link
Owner

I went ahead and added these changes myself.
Sorry for taking 2 years for something that makes total sense and is easy to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xomaczar @miguelcobain