Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for engines #594

Merged
merged 16 commits into from
Jan 26, 2017
Merged

Support for engines #594

merged 16 commits into from
Jan 26, 2017

Conversation

enniel
Copy link
Contributor

@enniel enniel commented Dec 22, 2016

Add support for ember-engines. With lazy loading yet not worked.

@miguelcobain
Copy link
Owner

I have moved the templates from the app to addon folder in master.
Can you rebase?

I see you're pulling dependencies from npm now. That's very desirable.
Have you considered using ember-cli-node-assets? It provides a nice abstraction on the npm import story.
Example: https://github.com/miguelcobain/ember-sticky/blob/master/index.js#L8-L17

@knownasilya
Copy link
Contributor

@enniel which version of engines did you test against for lazy support?

@knownasilya
Copy link
Contributor

@John0x see if you can try this PR. It works for me. Just make sure to share the -document service to your engine.

@knownasilya
Copy link
Contributor

@miguelcobain this is ready I think. Seems to work with lazyloaded engines too.

@miguelcobain
Copy link
Owner

I'm just concerned that prism was removed from bower. Either ember-prism includes prism from npm or the conde highlighting stopped working in the demo app.

@John0x
Copy link

John0x commented Jan 26, 2017

This PR works for me too, would be great to see it being merged.

@miguelcobain miguelcobain merged commit 393a3d1 into miguelcobain:master Jan 26, 2017
@miguelcobain
Copy link
Owner

miguelcobain commented Jan 26, 2017

Thanks to the missing in action @enniel for starting this. :D
Thanks to @knownasilya @John0x and @mellatone for helping to test this.
This was merged and released. Have fun.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants