Upgrade eps@1.8.5 #726
Upgrade eps@1.8.5 #726
Conversation
|
@xomaczar we should bump ember-basic-dropdown version as well, to the same version that eps uses, right? |
|
Forgot about that -- absolutely. |
|
I'm concerned if this upgrade is just a matter of bumping versions. Please test if this upgrade breaks any functionality. |
|
You don't trust our test suite? |
|
@xomaczar unfortunately some things are still poorly tested, e.g paper-select, only two tests there |
|
But overall, I think we have very good tests. |
|
Upgrading to the latest ember-basic-dropdown breaks a bunch of things -- so
don't be concerned :), more fixes to come.
…On Wed, Jun 21, 2017 at 12:08 PM, Miguel Andrade ***@***.***> wrote:
But overall, I think we have very good tests.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#726 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB-8eUJF_GVWR-l1v7sMfrrtNEsPYvXvks5sGT_ggaJpZM4N05eB>
.
|
|
Took a look at this as I have personal interest in this upgrade and looked into upgrading but @xomaczar got there first with what looks like clean changes and nice removals of no longer needed code. Tried out the branch locally and tried the autocomplete, menu and select components without any issues. Great work @xomaczar! :) |
|
Great PR. 👌 |
No description provided.