Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ember wormhole #915

Merged
merged 2 commits into from
May 10, 2018
Merged

Remove ember wormhole #915

merged 2 commits into from
May 10, 2018

Conversation

Subtletree
Copy link
Collaborator

@Subtletree Subtletree commented Apr 26, 2018

Replaces ember-wormhole with built in -in-element.

This mirrors the direction ember-basic-dropdown is going https://github.com/cibernox/ember-basic-dropdown/releases/tag/v1.0.0-beta.0

Fixes usage of ember-basic-dropdown 1.0.0 but won't work for ember < 2.10.

Uncaught Error: ember-wormhole failed to render content because the destinationElementId was set to an undefined or falsy value.

What versions do we support?

In my opinion if ember-basic-dropdown and ember-power-select are dropping support for Glimmer 1 apps, we should too in v1.0.0

@Subtletree
Copy link
Collaborator Author

Slack commentary on dropping < 2.10 support:

screen shot 2018-05-10 at 9 39 56 am

@miguelcobain miguelcobain merged commit 458a8db into miguelcobain:master May 10, 2018
@miguelcobain
Copy link
Owner

Thanks everyone.
We're still including ember-wormhole through ember-composability-tools, but this is a big step in the right direction.

@Subtletree Subtletree deleted the remove-ember-wormhole branch May 10, 2018 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants