Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANSI escape codes do not render consistantly #314

Closed
tgb20 opened this issue Jul 7, 2023 · 3 comments
Closed

ANSI escape codes do not render consistantly #314

tgb20 opened this issue Jul 7, 2023 · 3 comments

Comments

@tgb20
Copy link

tgb20 commented Jul 7, 2023

Describe the bug
ANSI escape codes are not showing colors consistently.

To Reproduce
Send a message with the following contents to a terminal:

�[31;1m[00:50:01 ERROR]: �[91mThis is red This is also red! �[92mThis is green �[97mAnd this is white�[0m
�[m[00:50:01 INFO]: �[91mThis is red This is also red! �[92mThis is green �[97mAnd this is white�[0m
�[33;1m[00:50:01 WARN]: �[91mThis is red This is also red! �[92mThis is green �[97mAnd this is white�[0m

The ? are escape characters, I am not sure how to share them properly

Expected behavior
All three lines are rendered with a different beginning log type and the same color text contents:

Screenshots

VSCode

VSCode preview

Xterm.js

Xterm.js

SwiftTerm

CleanShot 2023-07-06 at 20 53 42

Desktop (please complete the following information):

  • Xterm.js tested on Chrome 114.0.5735.198
  • VSCode tested using ANSI Colors

Smartphone (please complete the following information):

  • SwiftTerm tested on iPhone 14 Pro Max Simulator running iOS 16.2
  • SwiftTerm was also tested on various other iPhones with the same result
@migueldeicaza
Copy link
Owner

Perhaps this is your theme color you are using?

@tgb20
Copy link
Author

tgb20 commented Jul 8, 2023

I have not made any theme or rendering changes.

@migueldeicaza
Copy link
Owner

Thanks for the bug report, this was indeed my bug, but only got to my computer now.

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants