Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Posts" text gets placed wrong in modal (profile and hashtag search) if scrolled down in timeline #35

Closed
chrplace opened this issue Jan 15, 2014 · 7 comments · Fixed by #74
Labels
Milestone

Comments

@chrplace
Copy link

  1. should be at 2.
    twister_posts_placed_wrong
@BlockTester
Copy link
Contributor

I've also noticed this in Chromium Version 31.0.1650.63 Debian jessie/sid, though it's not always present.

@BlockTester
Copy link
Contributor

I noticed this happens when you open the mentions modal while the page is scrolled down but not when it's scrolled to the top.

@toyg
Copy link
Collaborator

toyg commented Jan 16, 2014

Ok, I see it.
It happens if, on the main screen, I scroll the postboard and then click on a username. Does not happen if I'm at the top of the post board. If there is a box saying "N new posts", that box is also appearing beside "Posts".

I guess those boxes are cloned from the Postboard top row, and if the postboard is not in the default position, they don't get the right location hint.

@chrplace
Copy link
Author

@toyg I have also seen the "X new posts" on the modal, but didn't get any while I was waiting to take the screen shot.

@toyg
Copy link
Collaborator

toyg commented Jan 17, 2014

This one is beyond my limited skills I fear... paging @dionyziz

@toyg
Copy link
Collaborator

toyg commented Jan 23, 2014

@BlockTester @chrplace can you please test this fix?

@chrplace
Copy link
Author

@toyg it fixes the main issue here of the "Posts" being wrongloy placed on the modal when the postboard is scrolled down.

I haven't been able to test the "X new posts" appearing in modal, when it should only be at th top of the postboard. But a separate issue should probably be created for that.

@toyg toyg closed this as completed in #74 Jan 23, 2014
toyg added a commit that referenced this issue Jan 23, 2014
Fix #35 - 'Posts' misplaced in profile modal if timeline was scrolled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants