Do not allow event names with hyphens in them

Fixes #36
miguelgrinberg · Jul 29, 2016 · a6838a2 · a6838a2
1 parent a3ae2a9
commit a6838a2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/socketio/server.py b/socketio/server.py
@@ -138,6 +138,8 @@ def message_handler(sid, msg):
         client's acknowledgement callback function if it exists. The
         ``'disconnect'`` handler does not take a second argument.
         """
+        if '-' in event:
+            raise ValueError('event names cannot contain hypens')
         namespace = namespace or '/'
 
         def set_handler(handler):

diff --git a/tests/test_server.py b/tests/test_server.py
@@ -45,6 +45,10 @@ def bar():
         self.assertEqual(s.handlers['/']['disconnect'], bar)
         self.assertEqual(s.handlers['/foo']['disconnect'], bar)
 
+    def test_on_bad_event_name(self, eio):
+        s = server.Server()
+        self.assertRaises(ValueError, s.on, 'two-words')
+
     def test_emit(self, eio):
         mgr = mock.MagicMock()
         s = server.Server(client_manager=mgr)