Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pin aio-pika #897

Closed
dimastbk opened this issue Mar 23, 2022 · 1 comment · Fixed by #900
Closed

pin aio-pika #897

dimastbk opened this issue Mar 23, 2022 · 1 comment · Fixed by #900
Labels
question

Comments

@dimastbk
Copy link
Contributor

In aio-pika, sync context manager of Incoming Message was deprecated in 5.0.0 (mosquito/aio-pika#193) and was removed in 7.0.0 (mosquito/aio-pika#436).

Maybe pin aio-pika<7 or change asyncio_aiopika_manager.py#L96 to use an async context manager and pin aio-pika>=5.
@miguelgrinberg
Copy link
Owner

I would prefer to update the code to work with the latest version of this dependency. Would you like to submit a PR with this change?

dimastbk added a commit to dimastbk/python-socketio that referenced this issue Mar 27, 2022
@dimastbk
fixed miguelgrinberg#897: compatibility with aio-pika=7
1d0b875
@dimastbk dimastbk mentioned this issue Mar 27, 2022
Merged
miguelgrinberg pushed a commit that referenced this issue Mar 27, 2022
@dimastbk
fixed #897: compatibility with aio-pika>=7 (#900)
b4b55e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

compatibility with aio-pika=7 dimastbk/python-socketio
2 participants
@miguelgrinberg @dimastbk