Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update win32 please #1255

Closed
kirill-21 opened this issue Apr 6, 2023 · 3 comments · Fixed by #1266
Closed

Update win32 please #1255

kirill-21 opened this issue Apr 6, 2023 · 3 comments · Fixed by #1266
Assignees
@philenius
Labels
desktop The issue applies to Windows, Linux or MacOS implementations. improvement Improvement needed on a specific feature

Comments

@kirill-21
Copy link
Contributor

image
@philenius philenius added improvement Improvement needed on a specific feature desktop The issue applies to Windows, Linux or MacOS implementations. labels Apr 6, 2023
@philenius
Copy link
Collaborator

Good point!

Same issue: #1222

I'm planning to merge the bugfix branch that I'm currently working on and then release a new major version of file_picker with win32 4.1.1.

@github-actions
Copy link

This issue is stale because it has been open for 14 days with no activity.

@github-actions github-actions bot added the stale label Apr 14, 2023
@philenius philenius removed the stale label Apr 14, 2023
@philenius philenius self-assigned this Apr 14, 2023
@OutdatedGuy OutdatedGuy mentioned this issue Apr 15, 2023
Closed
@philenius
Copy link
Collaborator

I will fix #1257 first, and then bump the win32 version. As of right now, I'm still undecided whether we should bump our major or minor version after updating win32. SemVer does not specify how to handle major dependency upgrades and there are several discussions, e.g.:

@philenius philenius linked a pull request Apr 19, 2023 that will close this issue
#1255: update dependency win32 to latest major v4 #1266
Merged
philenius added a commit that referenced this issue Apr 21, 2023
@philenius
Merge pull request #1266 from miguelpruivo/feature/#1255-update-depen…
ae93637 
…dencies

#1255: update dependency `win32` to latest major v4
@philenius philenius mentioned this issue Apr 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philenius philenius

Labels
desktop The issue applies to Windows, Linux or MacOS implementations. improvement Improvement needed on a specific feature
Projects
None yet
Milestone
No milestone
2 participants
@philenius @kirill-21