Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different Directory Picker on Windows #915

Closed
PeterNjeim opened this issue Dec 8, 2021 · 14 comments · Fixed by #971
Closed

Different Directory Picker on Windows #915

PeterNjeim opened this issue Dec 8, 2021 · 14 comments · Fixed by #971
Assignees
Labels
desktop The issue applies to Windows, Linux or MacOS implementations. stale suggestion New feature or request

Comments

@PeterNjeim
Copy link

PeterNjeim commented Dec 8, 2021

Hello, I (as well as most others) seriously dislike the directory chooser/picker that was chosen for the Windows implementation of this plugin. I feel completely paralyzed using it. I always think of old programs when I see this kind of directory picker. Normally, a directory chooser should look exactly the same as a file chooser, just that the files aren't visible. This is how it's done in virtually every program I've ever used. Please consider updating to the newer Vista+ folder selector using one of the methods listed in the "edit" section of the top answer from this q&a: https://stackoverflow.com/questions/1922204/open-directory-dialog.

@PeterNjeim PeterNjeim added the suggestion New feature or request label Dec 8, 2021
@philenius philenius added the desktop The issue applies to Windows, Linux or MacOS implementations. label Dec 10, 2021
@github-actions
Copy link

This issue is stale because it has been open for 14 days with no activity.

@github-actions github-actions bot added the stale label Dec 18, 2021
@PeterNjeim
Copy link
Author

Well, I suppose 9 days is close enough to 14 for your bot there lol

@github-actions github-actions bot removed the stale label Dec 19, 2021
@github-actions
Copy link

This issue is stale because it has been open for 14 days with no activity.

@github-actions github-actions bot added the stale label Dec 27, 2021
@philenius philenius removed the stale label Dec 27, 2021
@github-actions
Copy link

github-actions bot commented Jan 4, 2022

This issue is stale because it has been open for 14 days with no activity.

@github-actions github-actions bot added the stale label Jan 4, 2022
@philenius philenius removed the stale label Jan 16, 2022
@github-actions
Copy link

This issue is stale because it has been open for 14 days with no activity.

@github-actions github-actions bot added the stale label Jan 24, 2022
@philenius
Copy link
Collaborator

philenius commented Jan 26, 2022

@PeterNjeim I do understand your request. This

Screenshot 2022-01-26 223210

looks much better than that:

image

Thank you for providing the link to StackOverflow. Unfortunately, we cannot reference .NET libraries (which must be pre-installed on Windows). The Win32 API is special in that these DLLs (comdlg32.dll, shell32.dll, etc.) seem to be present on every Windows installation.

Until now I couldn't figure out which API provides the modern dialog. Currently, we're using SHBrowseForFolderW from Win32 API which opens this old-fashioned dialog. In the remarks it says:

For Windows Vista or later, it is recommended that you use IFileDialog with the FOS_PICKFOLDERS option rather than the SHBrowseForFolder function.

Maybe the solution is to switch to IFileDialog. We'll just have to figure out how to use the IFileDialog API.

@philenius philenius removed the stale label Jan 26, 2022
@PeterNjeim
Copy link
Author

I think that's the correct next step

@github-actions
Copy link

github-actions bot commented Feb 3, 2022

This issue is stale because it has been open for 14 days with no activity.

@b34st80y
Copy link

The pub.dev entry ( https://pub.dev/packages/file_picker ) even shows an example of the modern windows file picker:

image

I thought maybe I was doing something wrong when I got the one from windows Vista. :p

@PeterNjeim
Copy link
Author

That's for file selection, not folder selection. And the Vista one is the new one, not the old one. I understand your comment, but since it doesn't really move the issue forward, there was really no point in posting it lol.

@philenius
Copy link
Collaborator

@PeterNjeim sorry for letting you wait so long. I have already found a working implementation of the modern folder picker dialog, but I have another open pull request which should be merged first. However, miguelruivo seems to be very busy as he hasn't even reacted on my latest pull request #953 within 13 days and I don't have permission to merge myself. Please be patient.

@github-actions
Copy link

This issue is stale because it has been open for 14 days with no activity.

@github-actions
Copy link

This issue is stale because it has been open for 14 days with no activity.

@github-actions github-actions bot added the stale label Feb 28, 2022
miguelpruivo added a commit that referenced this issue Feb 28, 2022
…ry-picker-on-windows

#915 modern directory picker on Windows
@philenius
Copy link
Collaborator

@PeterNjeim: the modern directory picker dialog is now available on pub.dev with file_picker version 4.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop The issue applies to Windows, Linux or MacOS implementations. stale suggestion New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants