Bugfix for incorrect result parsing of the save-file dialog on Windows #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philenius
changed the title
|
@YarostheLaunchpadder can you please confirm whether with this pull request the save-file dialog works as expected even when given a long default file name? |
Somehow, as opposed to the official documentation by Microsoft, if the save-file dialog is invoked with a long default file name (e.g. `abcdefghijklmnopqrstuvxyz0123456789.png`) and the user changed the file name to a short one (e.g. `test.txt`), then the field `lpstrFile` not only contains the selected file `test.txt` but also, separated by only one `null` character, some remaining part of the originally given default file name.
The screen recordings uploaded to GitHub worked fine on GitHub but would not be display on pub.dev. Hence, revert to committing GIF files to our Git repo.
philenius
force-pushed
the
bugfix/#1257-incorrect-result-parsing-save-file-windows
branch
from
fc9e7ab
to
cb95746
Compare
|
@philenius This seems to have fixed the issue, at least in my testing. |
miguelpruivo
approved these changes
Apr 19, 2023
miguelpruivo
deleted the
bugfix/#1257-incorrect-result-parsing-save-file-windows
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1257: Previously, the save-file dialog returned an incorrect result if
abcdefghijklmnopqrstuvxyz0123456789.png)and
Test).Then, in some cases,
file_pickerreturned a mixed result of the actually picked file and the default file name, e.g.C:\Users\user\Desktop\Test\6789.png.See screen recording for better understanding:
After this bugfix:
Additional changes:
Reverted my previous changes to the README. I replaced the MP4 screen recording videos by GIF files as the videos would not be rendered on pub.dev. I payed attention to keep the file sizes of the GIFs small.
Improved code coverage of the Windows implementation by adding additional tests (from 8.1% to 17.6%). Let's say, there's much potential for improvement 😁
Previously:
Now: