Fix #1455 NPE when compressing images from gallery on Android 14 #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 11, 2024 11:02
…roid 14 Compress used to happen by reading the file on disk, which is not allowed on Android 14+. The correct way is opening the content Uri with openInputStream().
navaronbracke
requested changes
Mar 12, 2024
android/src/main/java/com/mr/flutter/plugin/filepicker/FileUtils.java
Outdated
Show resolved
Hide resolved
navaronbracke
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
I'll leave it to @miguelpruivo to include this into a release, since I am not in the publisher group on Pub.
4 tasks
|
Merged. Thank you all. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compression is done by reading the file on disk, which is not allowed on Android 14+.
The correct way is opening the content Uri with openInputStream().