WASM support for Flutter web #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 8, 2024
pubspec.yaml
Outdated
| @@ -17,6 +17,8 @@ dependencies: | |||
| path: ^1.8.2 | |||
| win32: ^5.1.1 | |||
| cross_file: ^0.3.3+7 | |||
| js: ^0.7.1 | |||
There was a problem hiding this comment.
Is that intended?
It's not used anymore and doesn't work with WASM anyways :)
There was a problem hiding this comment.
it is a mistake, I removed it I don’t use it anyway
thanks
IchordeDionysos
approved these changes
Apr 8, 2024
|
@IchordeDionysos You have to be a team member of this project to pass CI approval requirements 😁 |
|
Yeah true :D But given I've looked over it, I figured it can't hurt :P |
navaronbracke
requested changes
Apr 16, 2024
lib/_internal/file_picker_web.dart
Outdated
| @@ -58,7 +60,9 @@ class FilePickerWeb extends FilePicker { | |||
| Completer<List<PlatformFile>?>(); | |||
|
|
|||
| String accept = _fileType(type, allowedExtensions); | |||
| InputElement uploadInput = FileUploadInputElement() as InputElement; | |||
| HTMLInputElement uploadInput = | |||
There was a problem hiding this comment.
Suggested change
| HTMLInputElement uploadInput = | |
| HTMLInputElement uploadInput = HTMLInputElement(); |
The constructor calls document.createElement under the hood.
lib/_internal/file_picker_web.dart
Outdated
| @@ -101,7 +105,12 @@ class FilePickerWeb extends FilePicker { | |||
| } | |||
| } | |||
|
|
|||
| for (File file in files) { | |||
| for (var i = 0; i < files.length; i++) { | |||
There was a problem hiding this comment.
Suggested change
| for (var i = 0; i < files.length; i++) { | |
| for (int i = 0; i < files.length; i++) { |
lib/_internal/file_picker_web.dart
Outdated
|
|
||
| //Add input element to the page body | ||
| _target.children.clear(); | ||
| var firstChild = _target.firstChild; |
There was a problem hiding this comment.
I'd prefer to use the real type instead of var here.
|
I added the change requests |
navaronbracke
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding WASM support to close
#1480
Test by Flutter Beta channel or master channel and build by the following command
flutter build web --wasm