Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Bump min Android SDK version #1530

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

navaronbracke
Copy link
Collaborator

@navaronbracke navaronbracke commented Jun 10, 2024

This PR updates the minimum Android SDK version to 21, to align with the current minimum on Flutter 3.22.

It also updates the compile & target SDK versions to 34 and fixes a versioning issue for win32.

In a follow-up PR, I will also migrate the plugin to Gradle 8.

Fix was tested by compiling and running the example app on an Android 14 device.

Fixes #1522
Fixes #1528
Fixes #1531

@Mik1337
Copy link

Mik1337 commented Jun 15, 2024

What's the progress on this ? This pr will solve a bug im facing !! :)

@navaronbracke
Copy link
Collaborator Author

I need to get a hold of a reviewer to get this approved first.

@navaronbracke
Copy link
Collaborator Author

cc @philenius Not sure if you could rubber stamp this one? Miguel seems to be busy at the moment.

@Mik1337
Copy link

Mik1337 commented Jun 15, 2024

As a temp fix, i updated the version number from my .pub-cache folder and it lets me build the project; the fix seems to work :)

I would love to just have it patched in the lib, so my team can use it without worrying to much; :)

@navaronbracke
Copy link
Collaborator Author

@Mik1337 I would advise against that, as a flutter clean will erase that change in your pub cache.

You could instead use a git dependency on this PR branch

@Mik1337
Copy link

Mik1337 commented Jun 15, 2024

yeah fair, that makes more sense;

@dkliss
Copy link

dkliss commented Jun 26, 2024

I am facing same issue on IOS, Android, MACOS..... For web it works...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants