Feature/validate filename for savefile dialog #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #926. Windows limits the characters allowed in file names. See: https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file
miguelpruivo
approved these changes
Jan 16, 2022
miguelpruivo
deleted the
feature/validate-filename-for-savefile-dialog
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #926.
Under Windows the save-file dialog did not open if the specified file name contained an illegal character. Windows prohibits the usage of reserved characters in file names. Now the exception
IllegalCharacterInFileNameExceptionis thrown if the specified file name contains forbidden characters.I also activated many more linter rules, but I had to disable avoid_print because
file_picker_io.dartcontains print statements.@miguelpruivo are you okay with my approach of throwing this custom exception? I'm open to suggestions for improvement.