languageId is javascript but path icon show javascriptreact

[tjx666]

@ionutvmi
I config the .jsx files the language to javascript, but the path suggestion list icon still javascriptreact.

[mihai-vlc]

The icon is not controlled by the autocomplete extension.
We only configure if the suggestion is a file or a folder.

You may want to use an extension like https://marketplace.visualstudio.com/items?itemName=vscode-icons-team.vscode-icons to customize the icons.

It has more options to fine tune the displayed icons:
https://github.com/vscode-icons/vscode-icons/wiki/FineTuning

[tjx666]

I create an issue to vscode microsoft/vscode#138250 (comment)

[tjx666]

I had fix it in my fork. just set completionItem.detail to real file path. @ionutvmi

[mihai-vlc]

Feel free to open a PR with the fix.

I can merge it and publish it.
@tjx666

[tjx666]

I have change a lot in my fork, with many other optimize and publish my own version. You can have look at my fork https://github.com/tjx666/path-autocomplete/commits/master. You have two choice:

1. If you would like to merge it, I would stop publish my own version and help maintain your version.
2. You can just add completion.detail = file.path; to PathAutocompleteProvider.ts at line 49

[mihai-vlc]

hi @tjx666 ,

In general, I am in favor of modernizing the codebase and adding new features to the extension.

I reviewed the changes on the fork and they look ok to me.

I don't have too much time allocated to open source these days but I am also happy to add you as a contributor directly to this repo if you want to maintain these and future changes directly here.

[tjx666]

@ionutvmi I have made a pr