Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to satisfy CRAN requests #15

Merged
merged 8 commits into from
Feb 27, 2023
Merged

Changes to satisfy CRAN requests #15

merged 8 commits into from
Feb 27, 2023

Conversation

mihaiconstantin
Copy link
Owner

This PR contains changes to satisfy the requests from CRAN. See below:

You still have \dontrun{} examples in:
AsyncBackend.Rd; make_logo.Rd; ProgressDecorator.Rd
Is this really necessary? If not please change them to \donttest{} or
let us know why you think that \dontrun{} is actually the right choice here.

Please make sure that you do not change the user's options, par or
working directory. If you really have to do so within functions, please
ensure with an *immediate* call of on.exit() that the settings are reset
when the function is exited.
e.g.:
...
old <- options() # code line i
on.exit(options(old)) # code line i+1
...
options(...) # somewhere after
...
e.g.: -> R/exports.r
If you're not familiar with the function, please check ?on.exit. This
function makes it possible to restore options before exiting a function
even if the function breaks. Therefore it needs to be called immediately
after the option change within a function.

Please fix and resubmit.

@mihaiconstantin mihaiconstantin self-assigned this Feb 27, 2023
@mihaiconstantin mihaiconstantin added the feature New feature or request label Feb 27, 2023
@mihaiconstantin mihaiconstantin merged commit 2e06f5e into main Feb 27, 2023
@mihaiconstantin mihaiconstantin deleted the cran/checks branch February 27, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant