Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring and minor fixes #21

Merged
merged 7 commits into from
Mar 15, 2023
Merged

Refactoring and minor fixes #21

merged 7 commits into from
Mar 15, 2023

Conversation

mihaiconstantin
Copy link
Owner

  • Replace expected \dontrun{} statements with try() calls
  • Use progress_log_path in class Options examples
  • Use bquote for progress logging injection instead of substitute
  • Rename ProgressDecorator to ProgressTrackingContext (i.e., incl. mentions in the codebase)
  • Add ... args to Service$get_output method

@mihaiconstantin mihaiconstantin merged commit 3e55fcc into main Mar 15, 2023
@mihaiconstantin mihaiconstantin deleted the refactor branch March 15, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mihaiconstantin