Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix silent errors during task execution inAsyncBackend #38

Merged
merged 3 commits into from
May 7, 2023

Conversation

mihaiconstantin
Copy link
Owner

Closes #35.

@codecov
Copy link

codecov bot commented May 7, 2023

Codecov Report

Merging #38 (0c1ae23) into main (cd6c031) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
+ Coverage   98.57%   98.58%   +0.01%     
==========================================
  Files          18       18              
  Lines         422      425       +3     
==========================================
+ Hits          416      419       +3     
  Misses          6        6              
Impacted Files Coverage Δ
R/AsyncBackend.R 98.13% <100.00%> (+0.05%) ⬆️

@mihaiconstantin mihaiconstantin self-assigned this May 7, 2023
@mihaiconstantin mihaiconstantin added the bug Something isn't working label May 7, 2023
@mihaiconstantin mihaiconstantin merged commit 56e5bd1 into main May 7, 2023
9 checks passed
@mihaiconstantin mihaiconstantin deleted the fix/issue35 branch May 7, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

AsyncBackend does not bubble up errors to main session
1 participant