Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CD #83

Closed
mihaigalos opened this issue Jul 16, 2022 · 1 comment · Fixed by #84
Closed

Fix CD #83

mihaigalos opened this issue Jul 16, 2022 · 1 comment · Fixed by #84
Labels
bug Something's broken in here. feature

Comments

@mihaigalos
Copy link
Owner

Because of a missing schema definition (sftp), aim is currently using a hard fork of rust-url.
This means cargo publish will fail in the CD pipeline, because we cannot publish a crate that relies on git deps.

This PR tried to contribute changes upstream but got closed.

url-parse, once reaching maturity, will be able to unblock the blocked pipeline.
@mihaigalos mihaigalos mentioned this issue Jul 16, 2022
Merged
@mihaigalos
Copy link
Owner Author

CD pipeline green, badge displayed as red incorrectly.

Issue reported.

@mihaigalos mihaigalos added bug Something's broken in here. feature labels Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something's broken in here. feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate to using url-parse instead of url mihaigalos/aim
1 participant
@mihaigalos