Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the format of source files in src/ on CI #598

Merged
merged 4 commits into from
Dec 25, 2022

Conversation

toku-sa-n
Copy link
Collaborator

@toku-sa-n toku-sa-n commented Sep 22, 2022

The purpose is

  • To improve readability.
  • To test HIndent with an actual project.
  • To minimize a commit diff.

#599 #636 is a PR to pass all tests.

The purpose is
- To improve the readability.
- To test HIndent with an actual project.
- To minimize a commit diff.
@mihaimaruseac
Copy link
Owner

Let's punt on this until #599 first lands since we'll need to retest CI

mihaimaruseac
mihaimaruseac previously approved these changes Dec 25, 2022
Copy link
Owner

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try now

mihaimaruseac
mihaimaruseac previously approved these changes Dec 25, 2022
@toku-sa-n
Copy link
Collaborator Author

It seems like Windows' pwsh doesn't expand asterisks. Do we add a step for Windows, or use bash anytime?

@mihaimaruseac
Copy link
Owner

Let's go with this as it is. I'm planning a refactoring of actions over the next week and after that we can do a new release.

Thank you very much for the PRs you've sent!

@mihaimaruseac mihaimaruseac merged commit 3a6e32d into mihaimaruseac:master Dec 25, 2022
@toku-sa-n toku-sa-n deleted the check_format_on_ci branch December 25, 2022 01:06
@toku-sa-n
Copy link
Collaborator Author

Okay, thanks. I'm looking forward to the new release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants