Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix behaviour with QualifiedDo #696

Merged
merged 4 commits into from
Apr 5, 2023
Merged

Fix behaviour with QualifiedDo #696

merged 4 commits into from
Apr 5, 2023

Conversation

NathanielB123
Copy link
Contributor

@NathanielB123 NathanielB123 commented Apr 5, 2023 •
edited by toku-sa-n
Loading

We need to get out the module name from DoExpr and MDoExprs and potentially print it (if it is not Nothing).

Fixes: #695

@NathanielB123
Fix behaviour with QualifiedDo
d30c7c2 
We need to get out the module name from `DoExpr` and `MDoExpr`s and
potentially print it.
@NathanielB123 NathanielB123 mentioned this pull request Apr 5, 2023
Closed
@toku-sa-n toku-sa-n self-requested a review April 5, 2023 02:03
toku-sa-n
toku-sa-n previously approved these changes Apr 5, 2023
View reviewed changes
@toku-sa-n
Copy link
Collaborator

Thank you for the fix. Could you add this change to CHANGELOG.md?

@toku-sa-n toku-sa-n self-requested a review April 5, 2023 03:03
@NathanielB123
Copy link
Contributor Author

Thank you for the fix. Could you add this change to CHANGELOG.md?

Done!

@toku-sa-n
Update CHANGELOG.md
9d7625a 
Fix a linking issue
@toku-sa-n
Update CHANGELOG.md
fd06793 
Fix the issue number
toku-sa-n
toku-sa-n approved these changes Apr 5, 2023
View reviewed changes
Copy link
Collaborator

@toku-sa-n toku-sa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@toku-sa-n toku-sa-n merged commit d253186 into mihaimaruseac:master Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toku-sa-n toku-sa-n toku-sa-n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Qualified Do is Removed on Format
2 participants
@NathanielB123 @toku-sa-n