Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog for release #744

Merged
merged 4 commits into from
May 17, 2023
Merged

Update changelog for release #744

merged 4 commits into from
May 17, 2023

Conversation

mihaimaruseac
Copy link
Owner

Description of the PR

Checklist

Signed-off-by: Mihai Maruseac <mihai.maruseac@gmail.com>
@toku-sa-n
Copy link
Collaborator

I think the next version should be 6.1.0 as there are breaking changes (like reformat's signature change). After that version, we should be able to increment the patch number as long as we don't modify exposed contents in the HIndent module.

Signed-off-by: Mihai Maruseac <mihai.maruseac@gmail.com>
@mihaimaruseac
Copy link
Owner Author

Right, thanks for noticing. Updated

CHANGELOG.md Show resolved Hide resolved
Signed-off-by: Mihai Maruseac <mihai.maruseac@gmail.com>
Copy link
Collaborator

@toku-sa-n toku-sa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the .cabal file wasn't updated. Could you update it?

Signed-off-by: Mihai Maruseac <mihai.maruseac@gmail.com>
@mihaimaruseac
Copy link
Owner Author

Updated package.yaml, the .cabal file was updated before.

Copy link
Collaborator

@toku-sa-n toku-sa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mihaimaruseac mihaimaruseac merged commit e36786e into master May 17, 2023
19 of 20 checks passed
@mihaimaruseac mihaimaruseac deleted the changelog-bump branch May 17, 2023 14:04
@toku-sa-n
Copy link
Collaborator

Thanks for the release! Did you update the Hackage one?

@mihaimaruseac
Copy link
Owner Author

No, I had to leave for work. Just got home and will do the upload now.

@mihaimaruseac
Copy link
Owner Author

Now it should be at https://hackage.haskell.org/package/hindent-6.1.0 (documentation I think will be updated shortly, it's weird we only have the top level module only)

@toku-sa-n
Copy link
Collaborator

Thank you!

it's weird we only have the top level module only

It's expected as we did in #729.

@mihaimaruseac
Copy link
Owner Author

Oh, my bad, forgot about it.

Nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants