Add GHC 9.8.1 to the cabal CI #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mihaimaruseac Can I override this PR to support GHC 9.8, or should I create another PR? |
|
Up to you. I didn't get more time to look into it for the past few days :( |
Signed-off-by: Mihai Maruseac <mihai.maruseac@gmail.com>
Signed-off-by: Mihai Maruseac <mihai.maruseac@gmail.com>
mihaimaruseac
force-pushed
the
add-new-ghc
branch
from
3bb4270
to
176f631
Compare
|
I rebased to remove the merges from master back into the branch as those made understanding the changes harder |
|
Thank you! This seems to be going through now |
|
I cannot approve this since I started the PR, but this LGTMs. I enabled auto-merge, if you can approve it will merge automatically once tests finish. Otherwise, I'll force merge |
toku-sa-n
approved these changes
Nov 12, 2023
|
Thank you! I'll cut a new release tomorrow |
Closed
|
Thank you and sorry for the long delay. I'll fix the remaining warnings when I have time. |
|
No worries about the delay, I delayed this for too long myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the PR
Checklist
Part of #760