Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mmmagic an optionalDependency #16

Closed
thusoy opened this issue Nov 21, 2014 · 2 comments
Closed

Make mmmagic an optionalDependency #16

thusoy opened this issue Nov 21, 2014 · 2 comments
Assignees

Comments

@thusoy
Copy link
Contributor

thusoy commented Nov 21, 2014

The move from extension-based detectionto sniffing MIME-types in 1.1.0 with mmmagic causes installs to fail on platforms without a C compiler, such as Windows without Visual Studio.

Would be great if you could put mmmagic into optionalDependencies and detect on runtime whether it's available or not, and then fall back to the old extension-based detection, so that the plugin is installable on all platforms.

@mihhail-lapushkin
Copy link
Owner

Done.

@thusoy
Copy link
Contributor Author

thusoy commented Nov 21, 2014

Great, thanks for the quick response, with the missing line from #17 it works great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants