Add support for language availability check and download #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yjlim5 Thank you so much for the PR, I will review and update it. |
|
@mihirsoni thank you for providing this library and reviewing my PR! We have been using this library extensively as part of our language learning app. I was surprised to find that the speech part was not working on some of the latest Android devices, like Galaxy S8 - produced by Korea yet no Korean TTS voice installed by default. I hope the changes in this PR will help dealing with missing voice issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
speakfunction fails silently if the requested language is not supported on the device. To address this issue, this PR adds:speakthat requested language is not availablecheckLanguageAvailability(language)for checking language supportdownloadTTSVoice()for TTS Voice download pageTogether these changes will allow developers to easily detect and handle error cases where the language support is unavailable on Android device.