Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-monitor support, update logging, IL merge #17

Merged
merged 38 commits into from
Aug 21, 2018

Conversation

andyvans
Copy link
Contributor

@andyvans andyvans commented Aug 21, 2018

  1. Add support to clone to all system monitors. This involves cloning the primary windows with Mame to all BlankScreens windows using GDI.

  2. Added Serilog logging support to allow decent logging to assist diagnosing crashes. Debug logging goes to a file in the temp directory. Release logging goes to the event log. (Serilog won't crash if the event source doesn't exist - the old code did).

  3. To avoid needing to install required dependency dll files into c:\windows\system32, I have added an ILMerge build task to combine all assemblies into the single .SCR file.

  4. To exit the screen saver faster, perform a window minimise of Mame, then stop the process.

  5. Updated README.md - Added new pictures of Options window with Clone option. Updated contributors.

I appreciate there are a lot of changes in this PR.

andyvans and others added 30 commits August 12, 2018 17:01
@mika76
Copy link
Owner

mika76 commented Aug 21, 2018

Wow @andyvans this is great stuff! Will this clash at all with what @nullpainter is doing in #15?

Serilog won't crash if the event source doesn't exist - the old code did

Heh yeah 11 years ago we didn't have UAC 😆

@mika76
Copy link
Owner

mika76 commented Aug 21, 2018

Found a little issue - if the resolution is different - let's say smaller on the main mame screen and larger on a second screen, the clone does not cover the whole screen...

@nullpainter
Copy link
Contributor

Will this clash at all with what @nullpainter is doing in #15?

I'm guessing there may be a few little merge conflicts. Feel free to pull this PR first and I'll fix up any issues with #15 as a result.

@mika76 mika76 merged commit 90b70fd into mika76:master Aug 21, 2018
@mika76
Copy link
Owner

mika76 commented Aug 21, 2018

Cool. Merged. Fixes #9. This is a great addition! 💯 🥇

@mika76 mika76 added this to the v2.0 milestone Sep 3, 2018
@mika76 mika76 added this to Done in v2.0 Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants