Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE - Edit Vehicle Details #5

Closed
mikaelacaron opened this issue Sep 29, 2023 · 10 comments · Fixed by #269 · May be fixed by NamefulEntity/Basic-Car-Maintenance#1
Closed

FEATURE - Edit Vehicle Details #5

mikaelacaron opened this issue Sep 29, 2023 · 10 comments · Fixed by #269 · May be fixed by NamefulEntity/Basic-Car-Maintenance#1
Assignees
Labels
feature request New feature or request good first issue Good for newcomers hacktoberfest Any issue that can contribute to hacktoberfest help wanted Extra attention is needed

Comments

@mikaelacaron
Copy link
Owner

Describe the feature you want the app to have that it currently doesn't

  • Add a trailing swipe action to edit a vehcile's details that's on the SettingsView
  • A user would swipe left, tap on the action, and a sheet will be displayed (similar to the AddVehicleView) to edit the values of the vehicle
  • A leading navigation item will display an Update button which makes a call to Firebase to save the information

Describe alternatives you've considered

  • One alternative is to change the AddVehicleView to update the data, as well as add it (this requires keeping track of the state of the view whether you're in "adding" mode or "updating" mode)
    • The first way is easier, so I'd recommend doing that first

Additional context

  • Don't forget the the trailing action for Cancel that dismisses the view
@mikaelacaron mikaelacaron added feature request New feature or request hacktoberfest Any issue that can contribute to hacktoberfest design Change what something looks like good first issue Good for newcomers help wanted Extra attention is needed and removed design Change what something looks like labels Sep 29, 2023
@NamefulEntity
Copy link

I am going to start on this one. Just have to update Xcode and MacOS on my MacBook.

@Drag0ndust
Copy link
Contributor

@NamefulEntity are already working on this issue? if not @mikaelacaron I can take it

@mikaelacaron
Copy link
Owner Author

@Drag0ndust Give @NamefulEntity a few days, they just commented yesterday

@NamefulEntity
Copy link

NamefulEntity commented Oct 2, 2023

@mikaelacaron What's the deadline for submitting a PR on this feature?

@mikaelacaron
Copy link
Owner Author

@NamefulEntity and I chatted via DM he's going to work on this throughout the week, if he doesn't finish it by Oct 7, this is up for grabs and I'll change the assignee

@damien-rivet
Copy link

Hi @mikaelacaron,

Is this issue still available for grab or not? If it's the case I would gladly work on it.

@mikaelacaron
Copy link
Owner Author

mikaelacaron commented Oct 17, 2023

This issue is being worked on by @NamefulEntity , @damien-rivet you'll have to find a different issue to work on, thank you! I'll be adding more soon

@TratonGossink
Copy link
Contributor

@mikaelacaron I am starting to work on this one. If want to assign it to me that's ok. I'm gonna try and get it done this week. I know what has to be done just need to take the time to do it.

@mikaelacaron
Copy link
Owner Author

great thanks!

@mikaelacaron
Copy link
Owner Author

Closed with #269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request good first issue Good for newcomers hacktoberfest Any issue that can contribute to hacktoberfest help wanted Extra attention is needed
Projects
5 participants