Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completed initial French localization #131

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Completed initial French localization #131

merged 1 commit into from
Oct 11, 2023

Conversation

Dean151
Copy link
Contributor

@Dean151 Dean151 commented Oct 10, 2023

What it Does

How I Tested

  • Ran the application in French
  • Make a tour of the application to check translations context.

Notes

  • "Make" translation key is … vague. Adding a comment to tell it's the maker of the car would be interesting.

mikaelacaron
mikaelacaron approved these changes Oct 11, 2023
View reviewed changes
Copy link
Owner

@mikaelacaron mikaelacaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you!

@mikaelacaron mikaelacaron merged commit b0d3100 into mikaelacaron:dev Oct 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikaelacaron mikaelacaron mikaelacaron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Dean151 @mikaelacaron