Bug-Fix issue: 182 Picker in AddMaintainanceView is not working

[rramirez-dev]

Updated the vehicle picker to user the vehicle id and not the vehicle object

What it Does

• Closes BUG - Picker in AddMaintenanceView is not working #182
• Describe what your change does
  The fix allows the user to select a vehicle from the
  vehicle picker in the AddMaintainanceView form that
  is not the first vehicle in the list.

How I Tested

• Add a list of steps to show the functionality of your feature
  For example:
• Run the application
• Tap the (+) button
• See this screen
  etc...

1. Launch the App
2. Load the dashboard by navigating to a different tab and then select the dashboard tab again.
3. Tap the plus sign to add a new event
4. Enter a title
5. Select a vehicle that is not the first one on the list
6. Tap Add

Notes

• Anything else that should be noted about how you implemented this feature?
• I filtered the vehicles array based on the id of the vehicle that the user selected. I then get the first item in the array and pass it to the MaintainanceEvent view.

Screenshot

[mikaelacaron]

Can you make this work using the Vehicle object as opposed to the id? if not use the id and change the variable to selectedVehicleID
Also there's some indentation that's incorrect, your Xcode should be set to 4 spaces

[mikaelacaron]

nevermind sorry for the confusion, go ahead and use the id, that's how it's done in the AddOdometerReadingView

Also note you don't need the vehicle as Vehicle anymore because of that, and technically with the current way that you fixed this the if !vehicles.isEmpty check wouldn't be needed, because you made the selectedVehicle optional

[rramirez-dev]

So I should remove "vehicle as Vehicle" from the tag and replace it with "vehicle.id".

[mikaelacaron]

So I should remove vehicle as Vehicle from the tag and replace it with vehicle.id

Yes because it's not necessary to cast the vehicle as it's own type, the goal is to use the id as the main point of data for the picker, like you had it before

[mikaelacaron]

Good work! Just a small comment and I can merge this

[mikaelacaron]

Going to push a change to fix the alignment of this