Issue199 UI test #224
Issue199 UI test #224
Conversation
…to settingsviewmodel
|
So I did what you said |
This step, when you created the new branch, make sure it was created from the That's most likely what happened, I'll look at it more in-depth later Are you using Terminal to do git or some GUI? |
|
Terminal. What is the setting you use that indicates your on the dev. I usually see it on your live streams when your using the terminal. Right now I'm using default which is the original green one. |
|
I use this, which shows the branch I'm on rather than needing to type |
There was a problem hiding this comment.
Good work, it does technically add a vehicle, but an even better test would be to also confirm that the details from the vehicle that are added are also shown on the SettingsView
Because really what this is testing is that you an type into the text fields and press a button.
I'm going to manually fix your PR, but I'd suggest watching more videos about git and contributing to open source, because updating a feature branch is essential to know how to do. I think what you did was create a branch from your broken one that was never fixed, as opposed to making the branch from the dev branch. That's the only way the other commits "carried over"
| <<<<<<< HEAD | ||
| 8288B89A2AE5C5C900AA21F9 /* AddVehicleViewUITest.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AddVehicleViewUITest.swift; sourceTree = "<group>"; }; | ||
| ======= |
There was a problem hiding this comment.
This is what a merge conflict looks like, this is something you have to fix, and not commit
| func testAddVehicle() { | ||
| // Navigate to the AddVehicleView | ||
| app.buttons["Settings"].tap() | ||
| XCUIApplication().collectionViews/*@START_MENU_TOKEN@*/.buttons["Add Vehicle"]/*[[".cells.buttons[\"Add Vehicle\"]",".buttons[\"Add Vehicle\"]"],[[[-1,1],[-1,0]]],[0]]@END_MENU_TOKEN@*/.tap() |
There was a problem hiding this comment.
this /*@START_MENU_TOKEN@*/ stuff shouldn't be here. This is because you had Xcode auto fill something, but you never accepted it, look how it's "highlighted" you need to either double click on it, or click on it once and press enter to accept that as the code
There was a problem hiding this comment.
Also note you defined an app property in the class, yet here you're redefining using a new variable for XCUIApplication
There was a problem hiding this comment.
This test only works when there's one vehicle and that the Add Vehicle button is in the view immediately and you don't need to scroll to tap on it
|
See the final file changes, it's only a change to a single file, that's why I didn't want you to add a new file, when this is the only UI test in the project |
|
So since it was merged can I delete this branch? |
|
Yes it can be deleted from your fork |
|
And for next time I understand what I did wrong (Even though you have been telling me to do it this whole time it just takes me a minute for me to realize) So I was not on the dev branch, and that branch was not updated that's why it was so messed up. Also, I know now to make the branch off the dev branch(As you also said lol). Once again thanks for being patient with me, much appreciated! |
|
It doesn't matter "being on the But yes when you redid this, what you needed to do was first be on the To update your branch (you merge This is all a learning opportunity! That's the entire point of this project, because this stuff is hard to recreate if you're only learning by yourself |
What it Does