Skip to content

Commit

Permalink
Bumps all dependencies
Browse files Browse the repository at this point in the history
  • Loading branch information
@mikaelbr
mikaelbr committed Aug 4, 2019
1 parent 2bbcc2d commit 8f136d9
Show file tree
Hide file tree
Showing 3 changed files with 2,506 additions and 2,939 deletions.
1 change: 1 addition & 0 deletions .eslintrc
View file
Expand Up @@ -6,6 +6,7 @@
},
"rules": {
"space-before-function-paren": 0,
"no-prototype-builtins": 0,
"no-control-regex": 0
}
}

9 comments on commit 8f136d9

@SimenB
Copy link

@SimenB SimenB commented on 8f136d9 Aug 16, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change - some modules have dropped support for node 6 (which is fine in and of itself as it's EOL, but this commit was released as a patch)

@jnielson94
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimenB - Thanks for catching that and pointing it out! @mikaelbr - it looks like this was tagged in git as released but not actually pushed to npm? If that's the case we should probably wait to include these bumps in v6 and un-tag it.

@SimenB
Copy link

@SimenB SimenB commented on 8f136d9 Aug 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it has been untagged as latest, but it's definitely published

$ npm show node-notifier versions
...
  '5.0.1',
  '5.0.2',
  '5.1.2',
  '5.2.0',
  '5.2.1',
  '5.3.0',
  '5.4.0',
  '5.4.1',
  '5.4.2' ]

https://github.com/facebook/jest/pull/8831/files#diff-0fee7f28fe36fce7e695842f36311e39R25

@mikaelbr
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimenB Jeez, this is some terrible version management on my part. Sorry, all. I'll deprecate and release a patch reverting the breaking changes. It just didn't pay any attention and figured the breaking changes was all with devdependencies.

@SimenB
Copy link

@SimenB SimenB commented on 8f136d9 Aug 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries 🙂

@mikaelbr
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've deprecated the 5.4.2 version now, this should cause 5.4.1 to be used and avoid the issue. Let me know if there's anything else, @SimenB .

@jnielson94 I've also restructured and changed the master branch a bit (reverting breaking changes) to make it easier to do patch releases up until v6. I've moved the new breaking changes to v6 branch and created a WIP PR. But we should get the breaking changes out sooner rather than later. Should get snoreToast upgrade also

@SimenB
Copy link

@SimenB SimenB commented on 8f136d9 Aug 19, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you release a 5.4.3 with the reverts just to be safe?

EDIT: Oh, never mind 1101e6d 😀 Can you publish it as well?

@mikaelbr
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimenB It's published now. Would love if it you could verify that everything works as expected. There were some manual back and forth commit handling with reverting to make this happen, so hopefully I got everyone of them

@SimenB
Copy link

@SimenB SimenB commented on 8f136d9 Aug 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, works great! Thanks 🙂 jestjs/jest@b09de2d

It was only is-wsl that was breaking (for consumers at least) btw, upgrading semver should be safe

Please sign in to comment.