Use a more specific condition for debug output.

[pascaliske]

When someone uses visionmedia/debug for logging he has to set process.env.DEBUG for enabling his own log messages.
He always sees the following output, because node-notifier only checks for the presence of the env var (if (process.env.DEBUG)):

node-notifier debug info (fileCommandJson):
[notifier path] [...]/node_modules/node-notifier/vendor/terminal-notifier.app/Contents/MacOS/terminal-notifier
[notifier options] -title "xyz" -message "🎉 some message here" -json "true"

Instead of checking for the presence you could check for the package name inside of the env var. Then someone could enable debug logging for node-notifier with setting the env var to something like this:

process.env.DEBUG = 'some-other,notifier';

[mikaelbr]

Hi. Thanks for this. Didn't think would be an issue. Do you know, is it common to do DEBUG with operations like this, or would a better way to do e.g. process.env.NODE_NOTIFIER_DEBUG = true?

[pascaliske]

Hi, Yes I would say that this is a common usage. See the Usage-section of visionmedia/debug. 😃

[mikaelbr]

I'm merging this, but will have to do a major release as it is a major change. Will wait for the change in terminal-notifier as that is also a breaking change.

[mikaelbr]

Thanks for your work 🎉

[pascaliske]

Yeah, sure! Will use the master branch until you released the major version!

Thanks for merging, keep up the great work! 🤘🏻