Updates after notifu #297
Merged
Updates after notifu #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mikaelbr - I added a notifu (balloon) example, and did a couple other updates I'd like you to look at. I'm not a lawyer by any stretch, but I read the license in notifu (which is nice and permissive) and decided to try and clarify/update things to make sure we are good on the snoreToast license as well. I know you closed issue 275 about the license (which I agree with your position there), but I figured I'd try to make it more clear while I was looking at things for notifu's. Lemme know if something looks off or worries you 馃憤