Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implements proper timeout/wait behaviour for notify-send #341

Merged
merged 2 commits into from Aug 13, 2020

Conversation

@mikaelbr
Copy link
Owner

@mikaelbr mikaelbr commented Aug 10, 2020

Timeout/wait implementation seems to be lacking for Linux systems as of now. This PR tries to amend this. See facebook/jest#9701 for context.

Breaking change:

  • Changes the notify-send API to match macOS and Windows with seconds for timeout. Also sets timeout to default to 10 seconds.
@mikaelbr mikaelbr merged commit ee7916a into master Aug 13, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant