Added second and millisecond units to duration token #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
Looking good @mitchdotdeveloper! Great work and happy to merge this in. I will add your name to the list of contributors too and push this to a new release ASAP. |
|
Please find your additions now released in Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Mikael!
I am currently using figmagic at work, awesome project btw, as we build out our design system and thought this might be a worthwhile addition.
In this PR I added the units
sandms, seconds and milliseconds respectively, to thedurationtoken. In our use we found we were having to appendsto all of our duration tokens which is somewhat cumbersome.Currently I have duration units defaulting to
s, however I'm curious if you think it would be useful to have the duration units as an "opt-in" unit? Some cases like CSS will requiresormshowever these could also be used in JS withsetTimeoutfor example which does not have units attached and expects milliseconds.