-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add useLiteralFontFamilies option #174
feat: add useLiteralFontFamilies option #174
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Hi @opauloh! This is great work. Happy to merge this. Will cut a release of this ASAP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Happy to present https://github.com/mikaelvesavuori/figmagic/releases/tag/v4.5.6 |
That's Awesome! Thank you @mikaelvesavuori!!! 🍻 |
Summary
Hey all
At my team's Design System (and also other design systems I've seen around) we provide the Font Family token as the whole font family stack, including the fallbacks in case of missing fonts.
i.e:
Currently using Figmagic we can only grab one font per token, which means we need to add a step for creating a combined token with a token from Figma + the fallbacks, but the problem is that this way we don't have a Single Source of Truth for these particular tokens, since the code is different from what is on Figma.
We found out that it would be helpful if we had an option to do this directly on Figma to keep the Single Source of Truth and have the ability to import using Figmagic and avoid extra steps.
Description of the changes made
Screenshots
Example of how it would like in Figma
Example of how it would like in code:
Checklist