Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable rrd locking during cgi calls #428

Merged
merged 1 commit into from Jul 22, 2022

Conversation

bachandi
Copy link
Contributor

@bachandi bachandi commented Jul 5, 2022

For modules that need to call the cgi function internally an option to disable the locking would be nice. This way the update function can call the cgi function to produce plots from reports for example.

@mikaku
Copy link
Owner

mikaku commented Jul 11, 2022

Do you have a real use case for this?
Not that I'm contrary to it, just want to know why not using the global config for that.

@bachandi
Copy link
Contributor Author

For modules that produce some reports and need to run cgi method to produce the plots this is needed if the config specifies rrd_locking. This way it is possible to call the cgi method inside the update from time to time.

@mikaku mikaku merged commit 99fbc51 into mikaku:master Jul 22, 2022
@mikaku
Copy link
Owner

mikaku commented Jul 22, 2022

Thanks.

@bachandi bachandi deleted the inhibit_locking_env branch July 22, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants