fix yazi version checker for healthcheck #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, sorry that I had missed this. Thanks for the fix! I just bumped the required yazi version to the newest version of yazi because I want to have neovim rename open buffers that were also renamed in yazi. That part works now, but the healthcheck is still a bit broken. I will fix it soon (tm). |
|
I thought about it while afk and I feel like checking for GreaterEqual would make more sense than GreaterThen. I would have to check what the GreaterEqual method is called now, if there is one. |
|
I am currently running the latest nightly and I wonder if it has been changed in a recent version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vim.version.ge method doesn't exist on nvim 0.9.5.
vim.version.gt does and it seems to do what we want here.