Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix yazi version checker for healthcheck #5

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

ktzee
Copy link
Contributor

@ktzee ktzee commented Mar 26, 2024

The vim.version.ge method doesn't exist on nvim 0.9.5.
vim.version.gt does and it seems to do what we want here.

@mikavilpas
Copy link
Owner

Hi, sorry that I had missed this. Thanks for the fix!

I just bumped the required yazi version to the newest version of yazi because I want to have neovim rename open buffers that were also renamed in yazi.

That part works now, but the healthcheck is still a bit broken. I will fix it soon (tm).

@mikavilpas mikavilpas merged commit c99491a into mikavilpas:master Apr 5, 2024
4 of 6 checks passed
@ktzee
Copy link
Contributor Author

ktzee commented Apr 7, 2024

I thought about it while afk and I feel like checking for GreaterEqual would make more sense than GreaterThen. I would have to check what the GreaterEqual method is called now, if there is one.

@mikavilpas
Copy link
Owner

I am currently running the latest nightly and I wonder if it has been changed in a recent version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants